Skip to content

Conversation

@PabloDArandaR
Copy link
Contributor

Since it is a functionality allowed by the RTDEClient, seems reasonable to also add it to the UrDriver.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 42.63%. Comparing base (1d785d9) to head (c98ad77).

Files with missing lines Patch % Lines
src/ur/ur_driver.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   42.82%   42.63%   -0.19%     
==========================================
  Files          99       99              
  Lines        8636     8634       -2     
  Branches     1171     1171              
==========================================
- Hits         3698     3681      -17     
- Misses       4659     4673      +14     
- Partials      279      280       +1     
Flag Coverage Δ
start_ursim 81.54% <ø> (-3.13%) ⬇️
ur20-latest 40.65% <66.66%> (-0.12%) ⬇️
ur5-3.14.3 40.49% <66.66%> (-0.08%) ⬇️
ur5e-10.7.0 35.65% <66.66%> (-0.05%) ⬇️
ur5e-5.9.4 40.64% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex
Copy link
Member

urfeex commented Nov 14, 2025

Thank you for the contribution! I also wanted to do that a couple of times already, it just never wasn't important enough. I'll have to think a bit about potential side effects and we would need to add some tests for this.

@PabloDArandaR
Copy link
Contributor Author

I will think about the tests for starters, specially since with this change we are avoiding the error messages occurring when there is no recipe file defined for the driver (which throws an error with a wrong '' file message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants